Skip to content

RISC-V: set git committer via environment#117

Merged
mshabunin merged 1 commit intoopencv:mainfrom
mshabunin:fix-riscv-again
Oct 17, 2023
Merged

RISC-V: set git committer via environment#117
mshabunin merged 1 commit intoopencv:mainfrom
mshabunin:fix-riscv-again

Conversation

@mshabunin
Copy link
Copy Markdown
Contributor

@mshabunin mshabunin commented Oct 17, 2023

Looks like it's a git quirk/bug, because it does not make any commits with pull --no-ff --no-rebase --no-commit but requires user name/email to be set.

@mshabunin mshabunin mentioned this pull request Oct 17, 2023
Merged
@mshabunin mshabunin requested a review from asmorkalov October 17, 2023 11:28
asmorkalov
asmorkalov approved these changes Oct 17, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mshabunin mshabunin merged commit 0692b8b into opencv:main Oct 17, 2023
@mshabunin mshabunin deleted the fix-riscv-again branch October 17, 2023 13:25
@fengyuentau
Copy link
Copy Markdown
Member

fengyuentau commented Oct 17, 2023

Still not working, same error: https://github.com/opencv/opencv/actions/runs/6545660238/job/17781350654?pr=24409

I suspect that the reason is about user:

https://github.com/opencv-infrastructure/opencv-gha-dockerfile/blob/6b48bcb968f9150778d08d5eac390e15f9a38650/ubuntu-github-actions--22.04/Dockerfile#L78

Your riscv dockerfiles does not have this. Maybe the git configs you set is by some unknown user, so even root does not work.

@mshabunin
Copy link
Copy Markdown
Contributor Author

mshabunin commented Oct 17, 2023

Still not working, same error: https://github.com/opencv/opencv/actions/runs/6545660238/job/17781350654?pr=24409

This run does not get updated workflow (see "Set up job" step), it uses d0f18fc6430810ef77fc469a9b783445794657bc, but fixed one is 0692b8bdf3ab41cfc137a57be232b4d64214c2ae. I don't know how to force it to use updated pipeline commit, maybe make new commit?

@mshabunin
Copy link
Copy Markdown
Contributor Author

mshabunin commented Oct 17, 2023

Recent runs get updated commit and merging seems to be ok: https://github.com/opencv/opencv/actions/runs/6548709305

@fengyuentau
Copy link
Copy Markdown
Member

fengyuentau commented Oct 18, 2023

Thank you 👍

@fengyuentau
Copy link
Copy Markdown
Member

fengyuentau commented Oct 18, 2023

Seems like a connection problem now https://github.com/opencv/opencv/actions/runs/6555614757/job/17804315928?pr=24409.

@opencv-alalek
Copy link
Copy Markdown

opencv-alalek commented Oct 18, 2023

There is infrastructure issue. We are looking on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mshabunin @fengyuentau @opencv-alalek @asmorkalov