Skip to content

RISC-V workflows: initial version#111

Merged
asmorkalov merged 12 commits intoopencv:mainfrom
mshabunin:add-riscv
Oct 13, 2023
Merged

RISC-V workflows: initial version#111
asmorkalov merged 12 commits intoopencv:mainfrom
mshabunin:add-riscv

Conversation

@mshabunin
Copy link
Copy Markdown
Contributor

@mshabunin mshabunin commented Sep 11, 2023

@opencv-alalek opencv-alalek self-requested a review September 11, 2023 11:52
@mshabunin
Copy link
Copy Markdown
Contributor Author

mshabunin commented Sep 18, 2023

@asmorkalov , where can I get the print_system_information.sh script which should be located in the git_cache folder in all CI jobs?

@opencv-alalek
Copy link
Copy Markdown

opencv-alalek commented Sep 18, 2023

Just create empty / dummy print for testing.

Example:

OS: Ubuntu 20.04 LTS
CPU:
	 model: Intel(R) Xeon(R) Silver 4[21](https://github.com/opencv/opencv/actions/runs/6224002658/job/16891213155#step:3:22)0 CPU @ 2.20GHz
	 number of CPU: 2
	 total cores: 40
GPU:
	 model: NVIDIA Quadro P2000
	 number of GPU: 1
RAM:
	 size: 64GB

asmorkalov
asmorkalov reviewed Sep 20, 2023
View reviewed changes
@mshabunin mshabunin force-pushed the add-riscv branch 3 times, most recently from 5e5046d to c6531a1 Compare September 20, 2023 10:13
@mshabunin
Copy link
Copy Markdown
Contributor Author

mshabunin commented Sep 20, 2023

It started to work, but I'm not sure why only one pipeline had run (Contrib). Should I create separate PR for main pipeline?

@mshabunin mshabunin marked this pull request as ready for review September 21, 2023 09:39
asmorkalov
asmorkalov approved these changes Sep 21, 2023
View reviewed changes
asmorkalov
asmorkalov reviewed Sep 21, 2023
View reviewed changes
@mshabunin mshabunin mentioned this pull request Sep 21, 2023
Closed
@mshabunin mshabunin closed this Sep 21, 2023
@mshabunin mshabunin deleted the add-riscv branch September 21, 2023 18:05
@mshabunin mshabunin reopened this Sep 21, 2023
@mshabunin mshabunin mentioned this pull request Sep 29, 2023
Merged
@mshabunin
Copy link
Copy Markdown
Contributor Author

mshabunin commented Oct 3, 2023

@asmorkalov , @opencv-alalek , with new container (clang 16.0.6) all tests except one pass. I think this PR can be merged.

@opencv-alalek
Copy link
Copy Markdown

opencv-alalek commented Oct 3, 2023

Imgproc_Hist_Compare.accuracy

BTW, looks like it is a regression of OSoC refactoring:

https://pullrequest.opencv.org/buildbot/builders/4_x_riscv_rvv-clang-qemu-lin64?numbuilds=25

(failed since Sep 15)

@opencv-alalek opencv-alalek added the enhancement New feature or request label Oct 3, 2023
asmorkalov
asmorkalov approved these changes Oct 4, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hanliutong hanliutong mentioned this pull request Oct 4, 2023
Closed
4 tasks
opencv-alalek
opencv-alalek approved these changes Oct 10, 2023
View reviewed changes
Copy link
Copy Markdown

@opencv-alalek opencv-alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

BTW, it makes sense to add DNN tests too (without large models at least).

@asmorkalov asmorkalov merged commit 5348b13 into opencv:main Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@opencv-alalek opencv-alalek opencv-alalek approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mshabunin @opencv-alalek @asmorkalov