Fixed clang -Wdeprecated-copy warnings in OpenCV#33
Merged
dmatveev merged 1 commit intoopencv:masterfrom May 31, 2023
Merged
Conversation
dmatveev
approved these changes
Mar 12, 2023
Collaborator
dmatveev
left a comment
There was a problem hiding this comment.
Maybe @Hardcode84 has some comments on this? Fine for me, actually.
dmatveev
approved these changes
Mar 12, 2023
Collaborator
dmatveev
left a comment
There was a problem hiding this comment.
Maybe @Hardcode84 has some comments on this? Fine for me, actually.
dmatveev
approved these changes
May 31, 2023
Contributor
Author
|
@dmatveev , thank you! |
Collaborator
|
@mshabunin there was no enough content in master since then, if it is critical to include into the latest OpenCV then we can push a new tag for sure. |
Contributor
Author
|
Well, these warnings are quite annoying. Taking in account that previous minor release have been created to address similar problem, I think it's not a big issue. So I'm making a new minor-minor 🙂 release 0.1.2b. |
Collaborator
|
@mshabunin thanks a lot for taking care of this!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See http://eel.is/c++draft/class.copy.ctor#6 and https://bugs.llvm.org/show_bug.cgi?id=45634
I decided to implement copy constructor instead of removing explicit
operator=, hope it is correct.resolves #32