[fix] s3 user agent configuration is incorrect#2903
Merged
caoxianfei1 merged 1 commit intoopencurve:masterfrom Nov 20, 2023
Merged
[fix] s3 user agent configuration is incorrect#2903caoxianfei1 merged 1 commit intoopencurve:masterfrom
caoxianfei1 merged 1 commit intoopencurve:masterfrom
Conversation
Contributor
Author
|
cicheck |
1 similar comment
Contributor
Author
|
cicheck |
aspirer
requested changes
Nov 17, 2023
Contributor
aspirer
left a comment
There was a problem hiding this comment.
good job, but one more testcase can be added.
| std::array<std::string, 2>{"hello ", "hello"}, | ||
| std::array<std::string, 2>{" hello ", "hello"}, | ||
| std::array<std::string, 2>{" ", ""}, | ||
| std::array<std::string, 2>{"", ""}, |
Contributor
There was a problem hiding this comment.
we should add a case for middle space, such as " S3 Browser ", "S3 Browser", the expect trimed string is "S3 Browser".
|
@Ziy1-Tan squash into one commit. |
Contributor
This is not a requirement, it is a suggestion. |
Contributor
|
cicheck |
Contributor
Author
|
cicheck |
Signed-off-by: Ziy1-Tan <ajb459684460@gmail.com>
Contributor
Author
|
cicheck |
caoxianfei1
approved these changes
Nov 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #2898
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List