Skip to content

Remove metaleap code and replace with built in code#324

Merged
shawndwells merged 1 commit intoopencontrol:masterfrom
redhatrises:remove_metaleap_plugins
Aug 3, 2018
Merged

Remove metaleap code and replace with built in code#324
shawndwells merged 1 commit intoopencontrol:masterfrom
redhatrises:remove_metaleap_plugins

Conversation

@redhatrises
Copy link
Collaborator

  • Metaleap plugins aren't 32bit which is causing build failures, and only 3 functions are really used from Metaleap. Repo is also abandoned. This removes the plugins and adds "like" functionality.

@codecov
Copy link

codecov bot commented Jul 31, 2018

Codecov Report

Merging #324 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #324   +/-   ##
=======================================
  Coverage   79.06%   79.06%           
=======================================
  Files          38       38           
  Lines        1428     1428           
=======================================
  Hits         1129     1129           
  Misses        246      246           
  Partials       53       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5b89cc...0cbc9a4. Read the comment docs.

@redhatrises redhatrises force-pushed the remove_metaleap_plugins branch from 033bc4a to c9da2ab Compare July 31, 2018 19:04
@redhatrises redhatrises force-pushed the remove_metaleap_plugins branch from c9da2ab to 0cbc9a4 Compare July 31, 2018 19:06
@shawndwells shawndwells merged commit c64e676 into opencontrol:master Aug 3, 2018
@shawndwells
Copy link
Member

thanks @redhatrises !

@redhatrises redhatrises deleted the remove_metaleap_plugins branch August 3, 2018 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants