Codecov Report

Merging #317 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #317   +/-   ##
=======================================
  Coverage   79.09%   79.09%           
=======================================
  Files          38       38           
  Lines        1430     1430           
=======================================
  Hits         1131     1131           
  Misses        246      246           
  Partials       53       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f8739b...427a3b5. Read the comment docs.

@redhatrises the old and new way report different versions. Is this intended?

$ git for-each-ref --format="%(refname:short)" --sort=-authordate --count=1 refs/tags | cut -d"v" -f2
1.1.3

$ git describe --abbrev=0 --tags | cut -d"v" -f2
1.1.4

@shawndwells yes... the latest version is 1.1.4 not 1.1.3

Wasn't the question. The old way returned $ver-1, new way returns $ver.

Does this mean the old method always had a bug that is just now being exposed?

@shawndwells version 1.1.3 wasn't tagged correctly hence the old way was added. Now that version 1.1.4 was tagged correctly, this change uses the correct way of getting the tag for versioning.

thanks @redhatrises !