Skip to content

goreleaser updates#304

Merged
shawndwells merged 1 commit intoopencontrol:masterfrom
redhatrises:goreleaser_updates
Jun 20, 2018
Merged

goreleaser updates#304
shawndwells merged 1 commit intoopencontrol:masterfrom
redhatrises:goreleaser_updates

Conversation

@redhatrises
Copy link
Collaborator

  • Update goreleaser
  • Add usage template
  • Allow Makefile and goreleaser to build version into releases

@redhatrises redhatrises force-pushed the goreleaser_updates branch 2 times, most recently from 8734b01 to 2696b92 Compare June 19, 2018 17:36
@codecov
Copy link

codecov bot commented Jun 19, 2018

Codecov Report

Merging #304 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #304   +/-   ##
=======================================
  Coverage   79.25%   79.25%           
=======================================
  Files          38       38           
  Lines        1427     1427           
=======================================
  Hits         1131     1131           
  Misses        244      244           
  Partials       52       52

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43c0366...ce8b798. Read the comment docs.

@redhatrises redhatrises force-pushed the goreleaser_updates branch 2 times, most recently from 9ee04d1 to ecbfdee Compare June 19, 2018 21:32
- Update goreleaser
- Add usage template
- Allow Makefile and goreleaser to build version into releases
@redhatrises
Copy link
Collaborator Author

This should also fix #170

name: homebrew-compliance-masonry
commit_author:
name: OpenControl
email: dev@open-control.org
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this EMail exist?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawndwells figured you would know more than I about that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not something that's being changed in the PR, so no reason to hold a merge, just caught my eye.

version Display version

Flags:
Options:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

given the usage output, should this be renamed to command-options?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. It shouldn't.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bah

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean you're right.

default help behavior vs help get

var usage = `
Usage:
masonry [command]
masonry [global-options] COMMAND [command-options]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where are the global-options documented?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shawndwells In the help/usage outputs for each of the commands. For example, masonry help diff

@shawndwells shawndwells merged commit 721c996 into opencontrol:master Jun 20, 2018
@redhatrises redhatrises deleted the goreleaser_updates branch June 20, 2018 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants