Skip to content

Enable the use of files for components and don't fail on same repo#302

Merged
shawndwells merged 1 commit intoopencontrol:masterfrom
redhatrises:files_repos
Jun 15, 2018
Merged

Enable the use of files for components and don't fail on same repo#302
shawndwells merged 1 commit intoopencontrol:masterfrom
redhatrises:files_repos

Conversation

@redhatrises
Copy link
Collaborator

@redhatrises redhatrises commented Jun 14, 2018

@redhatrises redhatrises changed the title Enable the use of files for components and don't fail on same repo [WIP] Enable the use of files for components and don't fail on same repo Jun 14, 2018
@codecov
Copy link

codecov bot commented Jun 15, 2018 •
edited
Loading

Codecov Report

Merging #302 into master will decrease coverage by 0.26%.
The diff coverage is 65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
- Coverage   79.51%   79.25%   -0.27%     
==========================================
  Files          38       38              
  Lines        1411     1427      +16     
==========================================
+ Hits         1122     1131       +9     
- Misses        239      244       +5     
- Partials       50       52       +2
Impacted Files Coverage Δ
pkg/cli/get/resources/getter.go 88.67% <0%> (-2.59%) ⬇️
tools/vcs/manager.go 86.66% <76.47%> (-13.34%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d39a8...e3dbd76. Read the comment docs.

@redhatrises redhatrises force-pushed the files_repos branch 4 times, most recently from 3bb30e6 to a7cbcc8 Compare June 15, 2018 00:20
@redhatrises redhatrises changed the title [WIP] Enable the use of files for components and don't fail on same repo Enable the use of files for components and don't fail on same repo Jun 15, 2018
@shawndwells
Copy link
Member

shawndwells commented Jun 15, 2018

Receiving errors

$ ../../opencontrol/compliance-masonry/build/masonry get
An error occurred: readdirent: invalid argument

The opencontrol.yaml being used:

$ cat opencontrol.yaml 
schema_version: "1.0.0"
name: Template Information System
metadata:
  description: Template Information System
  maintainers:
    - Shawn Wells <shawn@redhat.com>

components:
#    - ./SI-System_and_Information_Integrity
#    - ./../../ComplianceAsCode/redhat-openstack-platform-13
#     - ./../../ComplianceAsCode/redhat-openshift-v3

dependencies:
  standards:
    - url: https://github.com/opencontrol/standards
      revision: master
  certifications:
    - url: https://github.com/opencontrol/certifications
      revision: master
  systems:
    - url: https://github.com/SecurityCentral/template-system-process-controls
      revision: opencontrol
    - url: https://github.com/ComplianceAsCode/redhat
      contextdir: osp13
      revision: opencontrol
    - url: https://github.com/ComplianceAsCode/redhat
      contextdir: ocp3
      revision: opencontrol
    - url: https://github.com/ComplianceAsCode/redhat
      contextdir: idm
      revision: opencontrol

@shawndwells
Copy link
Member

shawndwells commented Jun 15, 2018

recompiles on a clean environment takes care of the errors. ack.

@shawndwells shawndwells merged commit 80a4e06 into opencontrol:master Jun 15, 2018
@redhatrises redhatrises deleted the files_repos branch June 15, 2018 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@redhatrises @shawndwells