shadowed err variable created#229
Merged
jcscottiii merged 1 commit intoopencontrol:masterfrom Oct 6, 2016
jackielii:patch-1
Merged
shadowed err variable created#229jcscottiii merged 1 commit intoopencontrol:masterfrom jackielii:patch-1
err variable created#229jcscottiii merged 1 commit intoopencontrol:masterfrom
jackielii:patch-1
Conversation
it makes the return value always nil
Current coverage is 90.12% (diff: 100%)@@ master #229 diff @@
==========================================
Files 32 32
Lines 1013 1013
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 913 913
Misses 82 82
Partials 18 18
|
Member
|
great catch! thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it makes the return value always nil