layer: ignore overlay.impure xattr#354
Merged
cyphar merged 1 commit intoopencontainers:masterfrom Mar 6, 2021
Merged
Conversation
Member
Author
|
I suppose we should probably ignore all the overlay xattrs (e.g. opaque or other things) with similar kinds of semantics... perhaps I should switch this patch to just ignore all of them. Let me know what you think. |
Member
|
Yeah it might not make sense to include any |
Member
Author
|
Yeah, perhaps I'll just update this and add all of the existing ones now, I think there's only ~6. |
60efe0e to
0db4a03
Compare
See comment for details; basically these are during-image-build-time-only things. Signed-off-by: Tycho Andersen <tycho@tycho.pizza>
0db4a03 to
b171df2
Compare
Codecov Report
@@ Coverage Diff @@
## master #354 +/- ##
=======================================
Coverage 74.20% 74.20%
=======================================
Files 58 58
Lines 3078 3078
=======================================
Hits 2284 2284
Misses 464 464
Partials 330 330
|
Member
Author
|
Ping? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See comment for details; basically this is a during-image-build-time-only
thing.
Signed-off-by: Tycho Andersen tycho@tycho.pizza