Added support for zstd compression#350
Merged
tych0 merged 1 commit intoopencontainers:masterfrom Jan 14, 2021
Merged
Conversation
Using github.com/klauspost/compress go module has brought in a list of other compression implementations. Therefore the vendor folder has gotten larger. Some files were also modified due to the bump up in compress's version. Apart from these, this commit adds an implementation for zstd compression and a corresponding test. Fixes opencontainers#316 Signed-off-by: Nisha K <nishak@vmware.com>
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #350 +/- ##
==========================================
- Coverage 74.42% 74.20% -0.22%
==========================================
Files 58 58
Lines 3065 3078 +13
==========================================
+ Hits 2281 2284 +3
- Misses 459 464 +5
- Partials 325 330 +5
|
Member
|
Alright, now the CI has finally been wrangled I can review this (sorry about that). The main thing missing is that umoci cannot decompress zstd at the moment, and ideally I'd like it if we added support for that too (as well as a CLI UX for it). But I can work on that separately. So, LGTM and I'll work on those things separately. Thanks for the PR! |
Member
|
@tych0 LGTM from you as well? |
Member
|
Yep, sorry. LGTM as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using github.com/klauspost/compress go module has brought in a
list of other compression implementations. Therefore the vendor
folder has gotten larger. Some files were also modified due to
the bump up in compress's version.
Apart from these, this commit adds an implementation for zstd
compression and a corresponding test.
Fixes #316
Signed-off-by: Nisha K nishak@vmware.com