tar_extract: only warn once about xattr ENOTSUP#311
Merged
cyphar merged 1 commit intoopencontainers:masterfrom Jan 28, 2020
Merged
tar_extract: only warn once about xattr ENOTSUP#311cyphar merged 1 commit intoopencontainers:masterfrom
cyphar merged 1 commit intoopencontainers:masterfrom
Conversation
cyphar
reviewed
Jan 28, 2020
When a destination filesystem does not support xattrs we are rasing at least 1 ENOTSUP related warning per file. This is unhelpful, and can scroll the terminal obscuring more important warnings. Instead, show a single warning for the first occurrence, with an improved explanation of the cause. Signed-off-by: David Trudgian <dave@trudgian.net>
fc60ef7 to
a9fd512
Compare
dtrudg
commented
Jan 28, 2020
Member
|
LGTM. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a destination filesystem does not support xattrs we are rasing at
least 1 ENOTSUP related warning per file. This is unhelpful, and can
scroll the terminal obscuring more important warnings. Instead, show a
single warning for the first occurrence, with an improved explanation of
the cause.
Signed-off-by: David Trudgian dave@trudgian.net