Skip to content

test: add runc smoke-test#296

Merged
tych0 merged 2 commits intoopencontainers:masterfrom
cyphar:tests-improvement
Jun 23, 2020
Merged

test: add runc smoke-test#296
tych0 merged 2 commits intoopencontainers:masterfrom
cyphar:tests-improvement

Conversation

@cyphar
Copy link
Copy Markdown
Member

@cyphar cyphar commented Apr 8, 2019

We've had cases where the default setup of "umoci + runc" didn't work
(usually in rootless container scenarios). Since this is a very common
usage of umoci, it makes sense to check it.

Signed-off-by: Aleksa Sarai asarai@suse.de

@cyphar cyphar force-pushed the tests-improvement branch from d6b306c to 8ca423a Compare June 7, 2020 08:45
@cyphar cyphar force-pushed the tests-improvement branch from 8ca423a to a147355 Compare June 22, 2020 19:21
@cyphar

This comment has been minimized.

Sign in to view
@cyphar
Copy link
Copy Markdown
Member Author

cyphar commented Jun 23, 2020 •
edited
Loading

Okay, so the issue is (as usual) my fault. As part of the -j support in bats, bats-exec-test now runs in a context without stdin. For some reason this causes runc to fail (which might also be my fault):

% sudo ./runc run -b bundle ctr </dev/null
WARN[0000] exit status 2                    
ERRO[0000] container_linux.go:353: starting container process caused: process_linux.go:450: container init caused:

The temporary workaround is to set terminal: false, but I will open a bug report in runc about this (see opencontainers/runc#2485).

@cyphar cyphar mentioned this pull request Jun 23, 2020
Closed
@cyphar cyphar force-pushed the tests-improvement branch from a147355 to 62b7f28 Compare June 23, 2020 03:45
@cyphar
tests: correctly use testing.Skip
455b1eb 
Doing t.Log() followed by t.Skip() leaves a blank line in the test
output. Just pass the logging information to t.Skip().

Signed-off-by: Aleksa Sarai <asarai@suse.de>
@cyphar

This comment has been minimized.

Sign in to view
@cyphar cyphar force-pushed the tests-improvement branch 2 times, most recently from 781c69e to 2079e19 Compare June 23, 2020 07:22
@cyphar
test: add runc smoke-test
2a08aca 
We've had cases where the default setup of "umoci + runc" didn't work
(usually in rootless container scenarios). Since this is a very common
usage of umoci, it makes sense to check it.

Signed-off-by: Aleksa Sarai <asarai@suse.de>
@cyphar cyphar force-pushed the tests-improvement branch from 2079e19 to 2a08aca Compare June 23, 2020 07:42
@cyphar
Copy link
Copy Markdown
Member Author

cyphar commented Jun 23, 2020

LGTM.

/cc @tych0 @vbatts

@tych0
Copy link
Copy Markdown
Member

tych0 commented Jun 23, 2020

LGTM.

@tych0 tych0 merged commit fe482df into opencontainers:master Jun 23, 2020
@tych0
Copy link
Copy Markdown
Member

tych0 commented Jun 23, 2020

I just pressed github's merge button; let me know if I should be doing that differently :)

@cyphar
Copy link
Copy Markdown
Member Author

cyphar commented Jun 24, 2020 •
edited
Loading

That's perfectly fine. I personally prefer to use git merge --no-ff so that I can sign my merge commits and list who LGTM'd a change, but it's totally up to you.

@cyphar cyphar deleted the tests-improvement branch June 24, 2020 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cyphar @tych0