validation/util/container: Use ExitError for stderr#564
Merged
zhouhao3 merged 1 commit intoopencontainers:masterfrom Jan 29, 2018
Merged
validation/util/container: Use ExitError for stderr#564zhouhao3 merged 1 commit intoopencontainers:masterfrom
zhouhao3 merged 1 commit intoopencontainers:masterfrom
Conversation
Lean on the stdlib's ExitError [1] instead of passing stderr around separately. This makes it easy to keep all the parts of the error together, without having to worry about whether a particular command may have executed a runtime call. [1]: https://golang.org/pkg/os/exec/#ExitError Signed-off-by: W. Trevor King <wking@tremily.us>
Member
|
LGTM |
1 similar comment
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lean on the stdlib's
ExitErrorinstead of passing stderr around separately. This makes it easy to keep all the parts of the error together, without having to worry about whether a particular command may have executed a runtime call.