validate: With --host-specific, compare config platform vs. runtime

wking · wking · commit eda1ac76792e · 2016-08-16T22:09:46.000-07:00
This is a bit aggressive.  For example, maybe a Linux kernel was
compiled with CONFIG_64BIT, CONFIG_X86, and CONFIG_X86_X32.  Your
ocitools build may be 386 and validating an amd64 image (or vice
versa) and both would run fine.  I'm not sure x32 is supported by Go,
but you could have and x32 container if somebody submits it to the OCI
specs as an extention arch.  So I'd rather have an arch mismatch be a
warning than a fatal error.

But in most cases, you'll want the arch to match (e.g. no arm configs
if ocitools is amd64), so I don't want to ignore the missmatch
completely.  In the absence of warning-support, an overly strict check
seems safer than an overly lax check, because the caller can always
read the error messages and decide if they care ;).

Signed-off-by: W. Trevor King &lt;wking@tremily.us&gt;
diff --git a/cmd/ocitools/validate.go b/cmd/ocitools/validate.go
@@ -10,6 +10,7 @@ import (
 	"path"
 	"path/filepath"
 	"reflect"
+	"runtime"
 	"strings"
 	"unicode"
 	"unicode/utf8"
@@ -170,6 +171,16 @@ func checkPlatform(spec rspec.Spec, rootfs string, hostCheck bool) (msgs []strin
 	}
 	msgs = append(msgs, fmt.Sprintf("Operation system %q of the bundle is not supported yet.", platform.OS))
 
+	if hostCheck {
+		if platform.OS != runtime.GOOS {
+			msgs = append(msgs, fmt.Sprintf("platform.os is %s, not %s", platform.OS, runtime.GOOS))
+		}
+		if platform.Arch != runtime.GOARCH {
+			// warning, not an error, since kernels can support multiple architectures
+			msgs = append(msgs, fmt.Sprintf("platform.arch is %s, not %s", platform.Arch, runtime.GOARCH))
+		}
+	}
+
 	return
 }
 
