generate: Drop /dev/mqueue

wking · wking · commit 05c38271aba6 · 2015-12-05T12:55:14.000-08:00
Linux runtimes are not required to supply this [1,2]. We could supply it via ocitool, but I don't think its wise to try and define two standards (one in opencontainers/specs for what a runtime must supply, and another here with additional stuff), because I don't see a clear definition of something generally useful enough to go here but not in the spec. For example, hosts without CONFIG_POSIX_MQUEUE could be spec-compliant but unable to perform the mqueue mount I'm removing here. [1]: https://github.com/opencontainers/specs/blob/v0.1.1/config-linux.md#default-devices-and-file-systems [2]: opencontainers/runtime-spec#164 Signed-off-by: W. Trevor King <wking@tremily.us>
diff --git a/generate.go b/generate.go
@@ -528,12 +528,7 @@ func getDefaultTemplate() (specs.LinuxSpec, specs.LinuxRuntimeSpec) {
 				},
 			},
 			Hostname: "shell",
-			Mounts: []specs.MountPoint{
-				{
-					Name: "mqueue",
-					Path: "/dev/mqueue",
-				},
-			},
+			Mounts: []specs.MountPoint{},
 		},
 		Linux: specs.Linux{
 			Capabilities: []string{
@@ -556,13 +551,7 @@ func getDefaultTemplate() (specs.LinuxSpec, specs.LinuxRuntimeSpec) {
 	}
 	rspec := specs.LinuxRuntimeSpec{
 		RuntimeSpec: specs.RuntimeSpec{
-			Mounts: map[string]specs.Mount{
-				"mqueue": {
-					Type:    "mqueue",
-					Source:  "mqueue",
-					Options: []string{"nosuid", "noexec", "nodev"},
-				},
-			},
+			Mounts: map[string]specs.Mount{},
 		},
 		Linux: specs.LinuxRuntime{
 			Namespaces: []specs.Namespace{
