config-vm: Recycle the hook-process schema#962
Closed
wking wants to merge 2 commits intoopencontainers:masterfrom
Closed
config-vm: Recycle the hook-process schema#962wking wants to merge 2 commits intoopencontainers:masterfrom
wking wants to merge 2 commits intoopencontainers:masterfrom
Conversation
So we'll be able to link to it without linking the rest of the 'hooks' structure. Signed-off-by: W. Trevor King <wking@tremily.us>
We already have two ways to specify a process to launch (for the container process and for hooks). This commit recycles the hook-process schema for launching the hypervisor. I prefer using the more-fundamental container process schema, but Michael felt it had too many properties that wouldn't apply to the hypervisor-launching case [1]. [1]: opencontainers#949 (comment) Signed-off-by: W. Trevor King <wking@tremily.us>
Member
|
house keeping: i'm inclined to close this for now. While I am all for re-using schema, this slight change imposes a change and hitching VM intricacies to the other hooks (which sounds fine, but may not align to ongoing reality) |
Member
|
(decided to close, since the neither of the two reviewers have chimed in on this in 1.5yrs...) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've had two ways to specify a process to launch (for the container process and for hooks) for a while now. Last week, we landed #949 with a third process-launching structure. This pull request replaced that third structure with a recycled hook-process schema for launcing the hypervisor. I prefer using the more-fundamental container process schema, but @crosbymichael felt it had too many properties that wouldn't apply to the hypervisor-launching case. Versus master, this pull request adds:
argv[0]independently ofpath(likeexecvand similar).envandtimeoutfor the hypervisor process.And removes:
git diff --diffstat origin/master).argvphrasing which is much different from our existing phrasing.If we get this or a similar unification landed before we cut a release that includes #949, then I think this change is all positive with no downside. If we punt on this until after 1.1.0, then this is probably just going to end up as one of those unfortunate historical quirks that are not worth the migration pain of fixing.
Ping @sameo and @crosbymichael, since they're the only two who have expressed opinions on this sort of thing so far.