Skip to content

[1.4] Handle os.Is* wrapped errors correctly#5162

Merged
cyphar merged 2 commits intoopencontainers:release-1.4from
kolyshkin:1.4-5061
Mar 12, 2026
Merged

[1.4] Handle os.Is* wrapped errors correctly#5162
cyphar merged 2 commits intoopencontainers:release-1.4from
kolyshkin:1.4-5061

Conversation

@kolyshkin
Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin commented Mar 11, 2026

This is a backport of #5061 to release-1.4.

@curdbecker @kolyshkin
Replace os.Is* error checking functions with their errors.Is counterpart
34cb1b7 
Signed-off-by: Curd Becker <me@curd-becker.de>
(cherry picked from commit 536e183)
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@curdbecker @kolyshkin
Add linter rule to guard against use of os.Is* error functions
edb585e 
Signed-off-by: Curd Becker <me@curd-becker.de>
(cherry picked from commit 58d24d2)
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin added this to the 1.4.1 milestone Mar 11, 2026
@kolyshkin kolyshkin added the backport/1.4-pr A backport PR to release-1.4 label Mar 11, 2026
This was referenced Mar 11, 2026
Merged
Merged
Merged
@cyphar cyphar merged commit 6b36291 into opencontainers:release-1.4 Mar 12, 2026
41 checks passed
@cyphar
Copy link
Copy Markdown
Member

cyphar commented Mar 12, 2026

Oops, I hit "rebase and merged" but forgot that GitHub doesn't do git merge --no-ff in that case... :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lifubang lifubang lifubang approved these changes

@cyphar cyphar cyphar approved these changes

Assignees

No one assigned

Labels

backport/1.4-pr A backport PR to release-1.4

Projects

None yet

Milestone

1.4.1

Development

Successfully merging this pull request may close these issues.

4 participants

@kolyshkin @cyphar @lifubang @curdbecker