ci: add conmon tests run#5159
Conversation
fba6385 to
9def035
Compare
|
Added |
.github/workflows/test.yml
Outdated
|
|
||
| - name: build conmon | ||
| run: | | ||
| git clone --depth 1 https://github.com/containers/conmon |
There was a problem hiding this comment.
Would it be less fragile to use the latest release of conmon instead?
There was a problem hiding this comment.
That would be nice, but is there a simple way to do it? That's what I hate about GHA.
If dependabot can update the conmon version here, great. But otherwise, if we don't have an automated way to update it, I think I'd start with this and if it's noisy, we can always fall back to releases.
There was a problem hiding this comment.
I can checkout conmon via actions/checkout, like this:
- name: checkout conmon
uses: actions/checkout@v6
with:
repository: containers/conmon
path: conmon
ref: v2.2.1but even in that case dependabot won't be able to update it (unless I miss something).
There was a problem hiding this comment.
Let's settle on latest released version (and the need to update it manually, which is probably better than random CI failures).
There was a problem hiding this comment.
I was thinking you could use https://github.com/containers/conmon/releases/latest but this works fine too.
There was a problem hiding this comment.
Awesome, thanks @kolyshkin ! This mostly LGTM, left some simple comments.
.github/workflows/test.yml
Outdated
|
|
||
| - name: build conmon | ||
| run: | | ||
| git clone --depth 1 https://github.com/containers/conmon |
There was a problem hiding this comment.
That would be nice, but is there a simple way to do it? That's what I hate about GHA.
If dependabot can update the conmon version here, great. But otherwise, if we don't have an automated way to update it, I think I'd start with this and if it's noisy, we can always fall back to releases.
rata
left a comment
There was a problem hiding this comment.
LGTM. I'm fine if someone wants to do more improvements too, but I think this is good enough to merge. All the tests run in about 1min, that is great :)
This adds a CI job to run conmon tests with runc. Related to issue 5151, PR 5153. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
rata
left a comment
There was a problem hiding this comment.
Awesome, thank you very much for this improvement! LGTM
There was a problem hiding this comment.
Pull request overview
Adds CI coverage in the validate GitHub Actions workflow to build runc and run the upstream conmon test suite against it, ensuring validate gates on these results.
Changes:
- Introduce a new
conmonjob that installs deps, buildsrunc, checks outcontainers/conmon, builds it, and runs its tests. - Wire the new
conmonjob into theall-doneaggregator vianeeds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Nice! Do you think we should also add a test for |
👍 |
Makes sense! Perhaps podman and docker, too. |
Related to issue #5151, PR #5153.