conformance: poststart hooks spec now matches runc#5150
Merged
Conversation
Member
Author
|
See also #4348. |
Member
|
Needs rebase |
Contributor
|
@cyphar can you please rebase it? Guess we can include it to rc.1, too. |
kolyshkin
approved these changes
Mar 12, 2026
kolyshkin
left a comment
Contributor
There was a problem hiding this comment.
LGTM (but still needs a rebase)
This entry was added by commit 653161f ("docs/spec-conformance.md: update for spec v1.3.0") but the spec was updated before the v1.3.0 release to remove this requirement for poststart hooks in order to match runc's current behaviour. Fixes: 653161f ("docs/spec-conformance.md: update for spec v1.3.0") Ref: opencontainers/runtime-spec#1262 Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
ff071ea to
1c7b8c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This entry was added by commit 653161f ("docs/spec-conformance.md:
update for spec v1.3.0") but the spec was updated before the v1.3.0
release to remove this requirement for poststart hooks in order to match
runc's current behaviour.
Fixes: 653161f ("docs/spec-conformance.md: update for spec v1.3.0")
Ref: opencontainers/runtime-spec#1262
Signed-off-by: Aleksa Sarai cyphar@cyphar.com