Skip to content

keyring: validate: allow maintainers to have no keys#5144

Merged
cyphar merged 1 commit intoopencontainers:mainfrom
cyphar:keyring-check-no-keys
Mar 4, 2026
Merged

keyring: validate: allow maintainers to have no keys#5144
cyphar merged 1 commit intoopencontainers:mainfrom
cyphar:keyring-check-no-keys

Conversation

@cyphar
Copy link
Copy Markdown
Member

@cyphar cyphar commented Mar 4, 2026 •
edited
Loading

Some maintainers appear to have removed their PGP keys, which causes
"gpg --import" during "make validate-keyring" to fail. The solution is
to switch to a non-fatal warning if no keys were imported.

Fixes #5143
Signed-off-by: Aleksa Sarai cyphar@cyphar.com

@cyphar
keyring: validate: allow maintainers to have no keys
936a59b 
Some maintainers appear to have removed their PGP keys, which causes
"gpg --import" during "make validate-keyring" to fail. The solution is
to switch to a non-fatal warning if no keys were imported.

Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
@cyphar cyphar added backport/1.2-todo A PR in main branch which needs to be backported to release-1.2 backport/1.3-todo A PR in main branch which needs to be backported to release-1.3 backport/1.4-todo A PR in main branch which needs to backported to release-1.4 labels Mar 4, 2026
This was referenced Mar 4, 2026
Merged
Merged
Merged
rata
rata approved these changes Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@cyphar cyphar enabled auto-merge March 4, 2026 14:02
thaJeztah
thaJeztah approved these changes Mar 4, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, but I think my key should be fixed now (I deleted and re-uploaded it); suspect it's been some GitHub hiccup.

@cyphar cyphar merged commit b9303a6 into opencontainers:main Mar 4, 2026
63 of 64 checks passed
@cyphar cyphar deleted the keyring-check-no-keys branch March 4, 2026 14:11
@cyphar cyphar added backport/1.2-done A PR in main branch which has been backported to release-1.2 backport/1.3-done A PR in main branch which has been backported to release-1.3 backport/1.4-done A PR in main branch which has been backported to release-1.4 and removed backport/1.2-todo A PR in main branch which needs to be backported to release-1.2 backport/1.3-todo A PR in main branch which needs to be backported to release-1.3 backport/1.4-todo A PR in main branch which needs to backported to release-1.4 labels Mar 5, 2026
This was referenced Mar 12, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rata rata rata approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees

No one assigned

Labels

backport/1.2-done A PR in main branch which has been backported to release-1.2 backport/1.3-done A PR in main branch which has been backported to release-1.3 backport/1.4-done A PR in main branch which has been backported to release-1.4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

keyring validation broken

3 participants

@cyphar @rata @thaJeztah