libct/specconv: fix panic in initSystemdProps#5133
Merged
lifubang merged 2 commits intoopencontainers:mainfrom Feb 27, 2026
Merged
libct/specconv: fix panic in initSystemdProps#5133lifubang merged 2 commits intoopencontainers:mainfrom
lifubang merged 2 commits intoopencontainers:mainfrom
Conversation
cyphar
approved these changes
Feb 27, 2026
Use t.Run for individual tests. Add missing desc fields. Best reviewed with --ignore-all-space. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
There is a chance of panic here -- eliminate it. Add a test case (which panics before the fix). Reported-by: Luke Hinds <luke@stacklok.com> Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
lifubang
approved these changes
Feb 27, 2026
Contributor
Author
|
1.4 backport: #5161 |
This was referenced Mar 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a chance of panic here -- eliminate it.
Add a test case (which panics before the fix).
Reported-by: @lukefr09 (see #5130)