[1.2] Test/build using supported Go version#5112
Merged
kolyshkin merged 2 commits intoopencontainers:release-1.2from Feb 12, 2026
Merged
[1.2] Test/build using supported Go version#5112kolyshkin merged 2 commits intoopencontainers:release-1.2from
kolyshkin merged 2 commits intoopencontainers:release-1.2from
Conversation
In addition to testing with Go 1.22 (the oldest supported version in this branch, let's switch to using the supported Go versions (1.25 and 1.26) for CI, and using oldest supported Go version (1.25) for the official build. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Older one fails on ARM for some reason. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
AkihiroSuda
approved these changes
Feb 11, 2026
thaJeztah
reviewed
Feb 11, 2026
Comment on lines
40
to
42
| # Do race detection only on latest Go. | ||
| - race: -race | ||
| go-version: 1.22.x |
Member
There was a problem hiding this comment.
This comment doesn't look to match reality; looks like this one should be;
Suggested change
| # Do race detection only on latest Go. | |
| - race: -race | |
| go-version: 1.22.x | |
| # Do race detection only on latest Go. | |
| - race: -race | |
| go-version: 1.26.x |
Member
There was a problem hiding this comment.
It's true it doesn't match, but I'm not sure if we want to do it with the go version we do the releases or the latest one.
Member
There was a problem hiding this comment.
I tend to think the one we use for our official release is better, but it is really not that important
thaJeztah
reviewed
Feb 11, 2026
Comment on lines
34
to
35
| - criu: criu-dev | ||
| go-version: 1.22.x |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition to testing with Go 1.22 (the oldest supported version in this branch, let's switch to using the supported Go versions (1.25 and 1.26) for CI, and using oldest supported Go version (1.25) for the official build.
This should fix the CI failure (from a check added in #4998).
Also, bump bats-action (as the older one fails on ARM).
These are not backports because it's easier to patch than backport for such an old branch, and I want to minimize bumps.