Skip to content

libct/configs: mark MPOL_* constants as deprecated#5055

Merged
AkihiroSuda merged 1 commit intoopencontainers:mainfrom
kolyshkin:mpol-2
Dec 16, 2025
Merged

libct/configs: mark MPOL_* constants as deprecated#5055
AkihiroSuda merged 1 commit intoopencontainers:mainfrom
kolyshkin:mpol-2

Conversation

@kolyshkin
Copy link
Copy Markdown
Contributor

Alas, these new constants are already in v1.4.0 release so we can't remove those right away, but we can mark them as deprecated now and target removal for v1.5.0.

So,

  • mark them as deprecated;
  • redefine via unix.MPOL_* counterparts;
  • fix the validator code to use unix.MPOL_* directly.

This amends commit a0e809a (PR #4993).

@kolyshkin kolyshkin added the backport/1.4-todo A PR in main branch which needs to backported to release-1.4 label Dec 5, 2025
@kolyshkin kolyshkin added this to the 1.4.1 milestone Dec 5, 2025
@kolyshkin
Copy link
Copy Markdown
Contributor Author

The plan is to backport this to v1.4.1 so it's deprecated in there.

@kolyshkin kolyshkin requested a review from cyphar December 5, 2025 23:41
Alas, these new constants are already in v1.4.0 release so we can't
remove those right away, but we can mark them as deprecated now
and target removal for v1.5.0.

So,
 - mark them as deprecated;
 - redefine via unix.MPOL_* counterparts;
 - fix the validator code to use unix.MPOL_* directly.

This amends commit a0e809a.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@AkihiroSuda AkihiroSuda merged commit 4dcda05 into opencontainers:main Dec 16, 2025
37 of 38 checks passed
@kolyshkin kolyshkin removed this from the 1.4.1 milestone Feb 10, 2026
@kolyshkin kolyshkin added backport/1.4-done A PR in main branch which has been backported to release-1.4 and removed backport/1.4-todo A PR in main branch which needs to backported to release-1.4 labels Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/1.4-done A PR in main branch which has been backported to release-1.4 easy-to-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants