ci: ensure the cgroup parent always exists for rootless#5017
Merged
cyphar merged 1 commit intoopencontainers:mainfrom Nov 19, 2025
Merged
ci: ensure the cgroup parent always exists for rootless#5017cyphar merged 1 commit intoopencontainers:mainfrom
cyphar merged 1 commit intoopencontainers:mainfrom
Conversation
ea8be22 to
16de647
Compare
cyphar
reviewed
Nov 17, 2025
tests/rootless.sh
Outdated
Comment on lines
+103
to
+104
| sleep inf & | ||
| SID=$! |
Member
There was a problem hiding this comment.
It would be nice to have a (short) comment explaining what this is for, and SID should be a little more descriptive like CGROUP_PIN_PID or something.
Member
There was a problem hiding this comment.
Commit description could also use some of the explanation you added in #5003.
AkihiroSuda
reviewed
Nov 18, 2025
tests/rootless.sh
Outdated
| # a dummy process to pin the cgroup in place. | ||
| # See: https://github.com/opencontainers/runc/issues/5003 | ||
| sleep inf & | ||
| CGROUP_PIN_PID=$! |
Member
There was a problem hiding this comment.
Probably this should be set only on cgroup v1
On some systems (e.g., AlmaLinux 8), systemd automatically removes cgroup paths when they become empty (i.e., contain no processes). To prevent this, we spawn a dummy process to pin the cgroup in place. Fix: opencontainers#5003 Signed-off-by: lifubang <lifubang@acmcoder.com>
AkihiroSuda
approved these changes
Nov 19, 2025
Closed
cyphar
approved these changes
Nov 19, 2025
Member
cyphar
left a comment
There was a problem hiding this comment.
I still wonder what is causing this, but LGTM.
This was referenced Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On some systems (e.g., AlmaLinux 8), systemd automatically removes cgroup paths
when they become empty (i.e., contain no processes). To prevent this, we spawn
a dummy process to pin the cgroup in place.
Fix: #5003