Skip to content

ci: no need to test criu-dev#4983

Closed
lifubang wants to merge 1 commit intoopencontainers:mainfrom
lifubang:ci-remove-criu-dev
Closed

ci: no need to test criu-dev#4983
lifubang wants to merge 1 commit intoopencontainers:mainfrom
lifubang:ci-remove-criu-dev

Conversation

@lifubang
Copy link
Copy Markdown
Member

@lifubang lifubang commented Nov 8, 2025

It doesn’t seem particularly necessary to test CRIU’s criu-dev branch.

Signed-off-by: lifubang <lifubang@acmcoder.com>
@kolyshkin
Copy link
Copy Markdown
Contributor

The rationale to test criu-dev is at #3116. If we remove it, we'll have to deal with the future breakage after a new criu release. Now we can see issues before it is released.

@cyphar
Copy link
Copy Markdown
Member

cyphar commented Nov 11, 2025

I agree, though one thing to note is that in #3116 the CI job was not required for PRs to be merged, but since we switched to the complete setup for marking required jobs, it has become required. Any ideas of how we might deal with this? (I guess a re-usable workflow is the most GHA-friendly solution...)

@kolyshkin
Copy link
Copy Markdown
Contributor

CRIU issue is now fixed (see checkpoint-restore/criu#2781, checkpoint-restore/criu#2819). Alas, we have a different CI failure now (#5010) which for some reason happens with criu-dev but I can't see why.

Guess we can close this PR. I opened #5012 to make criu-dev "optional".

@kolyshkin kolyshkin closed this Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants