libct/cg: add test for remove a non-existent dir in a ro mount point#4526
Merged
kolyshkin merged 1 commit intoopencontainers:mainfrom Nov 15, 2024
Merged
Conversation
e9eb730 to
058b6f2
Compare
kolyshkin
reviewed
Nov 13, 2024
kolyshkin
reviewed
Nov 13, 2024
058b6f2 to
35800c8
Compare
AkihiroSuda
reviewed
Nov 14, 2024
AkihiroSuda
approved these changes
Nov 14, 2024
35800c8 to
11a33c5
Compare
11a33c5 to
cc74fd1
Compare
AkihiroSuda
approved these changes
Nov 14, 2024
kolyshkin
reviewed
Nov 14, 2024
libcontainer/cgroups/utils_test.go
Outdated
Comment on lines
+679
to
+681
| defer func() { | ||
| _ = unix.Unmount(dirTo, 0) | ||
| }() |
Contributor
There was a problem hiding this comment.
Sorry I overlooked it the first time. This defer should be added after the first mount, not after the second one. Not very important though since the second one shouldn't fail.
kolyshkin
approved these changes
Nov 14, 2024
Contributor
kolyshkin
left a comment
There was a problem hiding this comment.
one nit, but overall lgtm
Signed-off-by: lfbzhm <lifubang@acmcoder.com>
cc74fd1 to
119111a
Compare
Contributor
|
1.2 backport: #4531 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a unit test for the similar issue of #4518.