[1.2] libct: rm x/sys/execabs usage#4480
Merged
kolyshkin merged 1 commit intoopencontainers:release-1.2from Oct 26, 2024
Merged
Conversation
Since Go 1.19, the same functionality is there in os/exec package. As we require go 1.22 now, there's no need to have this. This basically reverts commit 9258eac ("libct/start: use execabs for newuidmap lookup"). Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit eb2ff52) Signed-off-by: Austin Vazquez <macedonv@amazon.com>
thaJeztah
approved these changes
Oct 26, 2024
Member
thaJeztah
left a comment
There was a problem hiding this comment.
oh! forgot we had it in this repo as well; I know I made a round to remove it from most places, but guess I forgot runc 🥹
LGTM, thanks!
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since Go 1.19, the same functionality is there in os/exec package. As we require go 1.22 now, there's no need to have this.
This basically reverts commit 9258eac ("libct/start: use execabs for newuidmap lookup").
(cherry picked from commit eb2ff52)