Merged
Conversation
AkihiroSuda
reviewed
Sep 23, 2024
libcontainer/init_linux.go
Outdated
| @@ -699,7 +699,7 @@ func setupPersonality(config *configs.Config) error { | |||
| // signalAllProcesses returns ErrNotRunning when the cgroup does not exist. | |||
Member
There was a problem hiding this comment.
This comment needs to be updated too
a89babc to
7055e85
Compare
For some rootless container, runc has no access to cgroup, But the container is still running. So we should return the `ErrNotRunning` and `ErrCgroupNotExist` error seperatlly. Signed-off-by: lifubang <lifubang@acmcoder.com>
7055e85 to
10c951e
Compare
AkihiroSuda
approved these changes
Sep 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some rootless container, runc has no access to cgroup, But the container is still running. So we should return the
ErrNotRunningandErrCgroupNotExisterror seperatlly.Follow up of #4395, please see #4395 (comment)