cc_platform.mk: only use when GOARCH is set explicitly#4349
Closed
kolyshkin wants to merge 1 commit intoopencontainers:mainfrom
Closed
cc_platform.mk: only use when GOARCH is set explicitly#4349kolyshkin wants to merge 1 commit intoopencontainers:mainfrom
kolyshkin wants to merge 1 commit intoopencontainers:mainfrom
Conversation
Current cc_platform.mk code assumes that if the value of GOARCH is the same as `go env GOARCH` output, we have a native build. This assumption is not correct when xx [1] is used to build runc (as it sets GOARCH etc in ~/.config/go/env file). Let's only include cc_platform when GOARCH is set from the environment of the command line. [1]: https://github.com/tonistiigi/xx Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Contributor
Author
|
Actually there's no need to have this either. |
Contributor
Author
Or, just use xx to set CC and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current cc_platform.mk code assumes that if the value of GOARCH is the same as
go env GOARCHoutput, we have a native build. This assumption is not correct when xx 1 is used to build runc (as it sets GOARCH etc in ~/.config/go/env file).Let's only include cc_platform when GOARCH is set from the environment of the command line.
Related: #4346, moby/moby#48160, moby/moby#47666.