Skip to content

ci: workaround for centos stream 8 being EOLed #4304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
AkihiroSuda merged 1 commit into from
Jun 4, 2024
Merged

ci: workaround for centos stream 8 being EOLed #4304

AkihiroSuda merged 1 commit into from
Jun 4, 2024

Conversation

@kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Jun 4, 2024 •
edited
Loading

CS8 is EOL. As a temp workaround, fix repo URLs to point to vault.

@kolyshkin
ci: workaround for centos stream 8 being EOLed
48c4e73 
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin added area/ci backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 labels Jun 4, 2024
@kolyshkin kolyshkin marked this pull request as ready for review June 4, 2024 00:40
This was referenced Jun 4, 2024
Closed
Merged
@AkihiroSuda
Copy link
Member

AkihiroSuda commented Jun 4, 2024

DCO check is hanging 🤔

@AkihiroSuda AkihiroSuda closed this Jun 4, 2024
@AkihiroSuda AkihiroSuda reopened this Jun 4, 2024
@thaJeztah
Copy link
Member

thaJeztah commented Jun 4, 2024

DCO check is hanging 🤔

Oh, I saw someone else mention that for another repository; perhaps some outage on GitHub?

Do we need to keep the stream-8, or should we just remove it? (Or is it purely an approximation for "RHEL 8" here?)

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Jun 4, 2024

Do we need to keep the stream-8, or should we just remove it? (Or is it purely an approximation for "RHEL 8" here?)

Let's keep it for now, this is an approximation for Rocky/Alma/Oracle Linux 8 too.

@thaJeztah
Copy link
Member

thaJeztah commented Jun 4, 2024

Yeah, probably ok for now; CentOS 7 will be EOL soon as well (but IIRC, so will RHEL 7, so ..)

For the DCO check; looks like it's currently broken; also running into that in other repositories now 😞

thaJeztah
thaJeztah approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

thaJeztah commented Jun 4, 2024

DCO ticket;

@AkihiroSuda
Copy link
Member

AkihiroSuda commented Jun 4, 2024

Let's merge this to unblock other PRs

@AkihiroSuda AkihiroSuda merged commit 3e8f48d into opencontainers:main Jun 4, 2024
@lifubang lifubang mentioned this pull request Jun 4, 2024
Merged
@lifubang lifubang added backport/1.1-done A PR in main branch which has been backported to release-1.1 and removed backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 labels Jun 4, 2024
@lifubang lifubang mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

area/ci backport/1.1-done A PR in main branch which has been backported to release-1.1 easy-to-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kolyshkin @AkihiroSuda @thaJeztah @lifubang