Skip to content

[1.1] libct/cg/fs: fix setting rt_period vs rt_runtime #4284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lifubang merged 1 commit into from
May 24, 2024
Merged

[1.1] libct/cg/fs: fix setting rt_period vs rt_runtime #4284

lifubang merged 1 commit into from
May 24, 2024

Conversation

@kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented May 21, 2024 •
edited
Loading

Backport of #4258 to release-1.1 branch.

The problem/fix is similar to one in #3084/#3090.

A test case (by @ls-ggg) is copied from #4235.

Fixes: #4094.

The issue is the same as in commit 1b2adcf but for RT scheduler; the fix is also the same.

Test case by @ls-ggg.

(cherry picked from commit b60079e)

@kolyshkin @ls-ggg
libct/cg/fs: fix setting rt_period vs rt_runtime
860f05f 
The issue is the same as in commit 1b2adcf but for RT scheduler;
the fix is also the same.

Test case by ls-ggg.

Co-authored-by: ls-ggg <335814617@qq.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
(cherry picked from commit b60079e)
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin added area/cgroupv1 backport/1.1-pr A backport PR to release-1.1 labels May 21, 2024
@kolyshkin kolyshkin mentioned this pull request May 21, 2024
Merged
@kolyshkin kolyshkin added this to the 1.1.13 milestone May 21, 2024
@kolyshkin kolyshkin changed the title libct/cg/fs: fix setting rt_period vs rt_runtime [1.1] libct/cg/fs: fix setting rt_period vs rt_runtime May 21, 2024
@kolyshkin
Copy link
Contributor Author

kolyshkin commented May 22, 2024

libcontainer/integration failed in ci / i386 job:

panic: getImages error exit status 1 (output: curl: (22) The requested URL returned error: 502 
curl: (22) The requested URL returned error: 502 
curl: (22) The requested URL returned error: 502 
curl: (22) The requested URL returned error: 502 
curl: (22) The requested URL returned error: 502 
curl: (22) The requested URL returned error: 502 
Failed to get https://github.com/docker-library/busybox/raw/461a473aef31b7726ea99909a24551bf44565c05/stable/glibc/busybox.tar.xz
)

goroutine 1 [running]:
github.com/opencontainers/runc/libcontainer/integration.init.1()
	/home/runner/work/runc/runc/libcontainer/integration/utils_test.go:37 +0x378
FAIL	github.com/opencontainers/runc/libcontainer/integration	31.526s

This is a temp issue with github downloads, now resolved.

@kolyshkin kolyshkin requested a review from lifubang May 24, 2024 05:21
@lifubang lifubang merged commit a12f444 into opencontainers:release-1.1 May 24, 2024
@lifubang lifubang mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lifubang lifubang lifubang approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

area/cgroupv1 backport/1.1-pr A backport PR to release-1.1

Projects

None yet

Milestone

1.1.13

Development

Successfully merging this pull request may close these issues.

3 participants

@kolyshkin @lifubang @AkihiroSuda