script/*: fix gpg usage wrt keyboxd #4189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
08ba435 to
063f944
Compare
cyphar
reviewed
Mar 13, 2024
063f944 to
5264e55
Compare
Contributor
Author
|
Addressed review comment; rebased. |
I used script/keyring_validate.sh, which gave me this error: > [*] User cyphar in runc.keyring is not a maintainer! Apparently, when gnupg 2.4.1+ sees a fresh install (i.e. no ~/.gnupg directory), it configures itself to use keyboxd instead of keyring files, and when just silently ignores options like --keyring and --no-default-keyring, working with keyboxd all the time. The only way I found to make it not use keyboxd is to set --homedir. Let's do that when we explicitly want a separate keyring. Similar change is made to script/release_key.sh. Also, change "--import --import-options=show-only" to "--show-keys" which is a shortcut. When using this, there is no need to protect the default keyring since this command does not read or modify it. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
5264e55 to
760105a
Compare
Contributor
Author
lifubang
approved these changes
Jun 8, 2024
Member
|
@kolyshkin Need to backport to 1.1? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used script/keyring_validate.sh, which gave me this error:
Apparently, when gnupg 2.4.1+ sees a fresh install (i.e. no ~/.gnupg directory), it configures itself to use keyboxd instead of keyring files, and when just silently ignores options like --keyring and --no-default-keyring, working with keyboxd all the time.
The only way I found to make it not use keyboxd is to set --homedir. Let's do that when we explicitly want a separate keyring.
Similar change is made to script/release_key.sh.
Also, change "--import --import-options=show-only" to "--show-keys" which is a shortcut. When using this, there is no need to protect the default keyring since this command does not read or modify it.