pull version from specs.Version instead of hardcoding; and make versi…#404
Closed
mikebrow wants to merge 1 commit intoopencontainers:masterfrom
Closed
pull version from specs.Version instead of hardcoding; and make versi…#404mikebrow wants to merge 1 commit intoopencontainers:masterfrom
mikebrow wants to merge 1 commit intoopencontainers:masterfrom
Conversation
…on check with spec a min version check Signed-off-by: Mike Brown <brownwm@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe the version tag should come from the specs package...
opencontainers/specs/version.goCorrect?Also modifying 'checkSpecVersion()' to be a min check vs. exact check. Otherwise we have to change versions in every container 'config.json' on every minor revision.
Associated with issue #244
Signed-off-by: Mike Brown brownwm@us.ibm.com