Skip to content

Conversation

@fish98
Copy link
Contributor

@fish98 fish98 commented Jun 25, 2023

Checkpoint integration test failed when running the tests inside the docker container instead of local environment: make integration TESTPATH="/checkpoint.bats. The error are shown below:

# /go/src/github.com/opencontainers/runc/tests/integration/checkpoint.bats: line 288: ip: command not found

Fixed by adding the missing package iproute into the Dockerfile.

Signed-off-by: TTFISH <jiongchiyu@gmail.com>
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kolyshkin kolyshkin merged commit 1bc2999 into opencontainers:main Jun 26, 2023
@kolyshkin
Copy link
Contributor

  1. This might need to be backported to 1.1.
  2. We're not hitting this in CI because we do not run tests through Docker.

@lifubang lifubang added the backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 label Jan 7, 2024
@kolyshkin
Copy link
Contributor

1.1 backport: #4241

@kolyshkin kolyshkin added backport/1.1-done A PR in main branch which has been backported to release-1.1 and removed backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci backport/1.1-done A PR in main branch which has been backported to release-1.1 easy-to-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants