Skip to content

[1.1] libct/cg: add misc controller to v1 drivers#3823

Merged
cyphar merged 1 commit intoopencontainers:release-1.1from
kolyshkin:1.1-misc
Apr 11, 2023
Merged

[1.1] libct/cg: add misc controller to v1 drivers#3823
cyphar merged 1 commit intoopencontainers:release-1.1from
kolyshkin:1.1-misc

Conversation

@kolyshkin
Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin commented Apr 10, 2023 •
edited
Loading

This is just so that

  • the container can join the misc controller;
  • the `Destroy() can actually remove the cgroup.

This should fix the issue reported in kubernetes/kubernetes#112124 (comment)

(cherry picked from commit 611bbac / PR #3815.

Proposed changelog entry:

- Bare minimal support for cgroup v1 misc controller. (#3823)

@kolyshkin
libct/cg: add misc controller to v1 drivers
e4ce94e 
This is just so that the container can join the misc controller.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
(cherry picked from commit 611bbac)
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin added this to the 1.1.6 milestone Apr 10, 2023
@kolyshkin kolyshkin mentioned this pull request Apr 10, 2023
Merged
@kolyshkin
Copy link
Copy Markdown
Contributor Author

kolyshkin commented Apr 10, 2023

This fixes the issue with Kubernetes and recent kernel adding misc controller.. I'm not exactly sure how misc controller is being created, but it's not being joined to or removed since runc knows nothing about it.

@cyphar
Copy link
Copy Markdown
Member

cyphar commented Apr 11, 2023

We probably want to make a proper MiscCgroup controller at some point since it's a real controller (I'm still not sure why it wasn't added to /sys/fs/resctl since that was created the last time a CPU-specific feature cgroup controller was proposed). But yeah, this is fine as a minimal implementation.

cyphar
cyphar approved these changes Apr 11, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cyphar cyphar merged commit 0690c4e into opencontainers:release-1.1 Apr 11, 2023
@dims dims mentioned this pull request Apr 27, 2023
Closed
This was referenced May 22, 2023
Merged
Merged
@jaxesn jaxesn mentioned this pull request Jan 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@cyphar cyphar cyphar approved these changes

@thaJeztah thaJeztah Awaiting requested review from thaJeztah

@hqhq hqhq Awaiting requested review from hqhq

@AkihiroSuda AkihiroSuda Awaiting requested review from AkihiroSuda

Assignees

No one assigned

Labels

area/cgroupv1 easy-to-review impact/changelog

Projects

None yet

Milestone

1.1.6

Development

Successfully merging this pull request may close these issues.

3 participants

@kolyshkin @cyphar @mrunalp