ci/gha: add ubuntu 22.04#3820
Merged
kolyshkin merged 1 commit intoopencontainers:mainfrom Apr 11, 2023
Merged
Conversation
AkihiroSuda
reviewed
Apr 8, 2023
12be6f8 to
e573cc5
Compare
5 tasks
Contributor
Author
|
Oh nice, actions/setup-go@v4 enables go cache caching by default, and it manages to bring some artefacts compiled on Ubuntu 22.04 to Ubuntu 20.04, resulting in weird linker errors. Filed actions/setup-go#368 |
cb4a9b5 to
6074098
Compare
Member
Yikes! |
For test jobs, add ubuntu 22.04 into the matrix, so we can test of both cgroup v1 and v2. For validate jobs, just switch to ubuntu 22.04 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Contributor
Author
|
No longer a draft. PTAL @AkihiroSuda @thaJeztah |
AkihiroSuda
approved these changes
Apr 11, 2023
thaJeztah
approved these changes
Apr 11, 2023
Member
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM
we need to update the list of required checks in branch protection, otherwise CI on PRs continue to be "pending", waiting for checks that no longer exist
samuelkarp
added a commit
to samuelkarp/containerd
that referenced
this pull request
May 8, 2023
actions/setup-go#368 and opencontainers/runc#3820 (comment) discuss issues with the cache key for actions/setup-go@v4. Rather than reverting the upgrade to v4 (per discussion in containerd#8372), disable caching explicitly. Signed-off-by: Samuel Karp <samuelkarp@google.com>
jsturtevant
pushed a commit
to jsturtevant/containerd
that referenced
this pull request
Sep 21, 2023
actions/setup-go#368 and opencontainers/runc#3820 (comment) discuss issues with the cache key for actions/setup-go@v4. Rather than reverting the upgrade to v4 (per discussion in containerd#8372), disable caching explicitly. Signed-off-by: Samuel Karp <samuelkarp@google.com>
juliusl
pushed a commit
to juliusl/containerd
that referenced
this pull request
Jan 26, 2024
actions/setup-go#368 and opencontainers/runc#3820 (comment) discuss issues with the cache key for actions/setup-go@v4. Rather than reverting the upgrade to v4 (per discussion in containerd#8372), disable caching explicitly. Signed-off-by: Samuel Karp <samuelkarp@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Ubuntu 22.04 to GHA CI test matrix, and switch from 20.04 to 22.04 for validate jobs.
Note that Ubuntu 22.04 uses cgroup v2.