Conversation
df79b02 to
8d9e5ed
Compare
|
Could you squash the commits? |
|
@AkihiroSuda Sure. Done. |
kolyshkin
left a comment
There was a problem hiding this comment.
left a few comments, mostly nits
223043c to
ca36f1e
Compare
docs/terminals.md
Outdated
|
|
||
| **Be very careful when passing file descriptors to a container process.** Due | ||
| to some Linux kernel (mis)features, a container with access to certain types of | ||
| to some Linux kernel misfeatures, a container with access to certain types of |
There was a problem hiding this comment.
We need to fix it to pass the checking code spell.
There was a problem hiding this comment.
Doesn't seem relevant to the PR
There was a problem hiding this comment.
But CI won't allow this word... if I edit this file, CI won't go through unless I fix this part.
There was a problem hiding this comment.
Please remove this hunk. We'll deal with CI later.
076fa1b to
9f7d118
Compare
a1980b1 to
cff9be2
Compare
|
This PR can be merged once you do a rebase and resolve the conflicts, and I can take over this PR if you are in busy status. |
|
@utam0k please avoid merge commits -- do a rebase instead |
Done ✅ |
|
@kolyshkin PTAL |
All request changes have been addressed.
|
@utam0k Please help to do a rebase to main and solve the conflicts. Thanks. |
docs/spec-conformance.md
Outdated
| @@ -9,6 +9,7 @@ Spec version | Feature | PR | |||
| -------------|------------------------------------------|---------------------------------------------------------- | |||
| v1.1.0 | `SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV` | [#3862](https://github.com/opencontainers/runc/pull/3862) | |||
| v1.1.0 | `.process.ioPriority` | [#3783](https://github.com/opencontainers/runc/pull/3783) | |||
There was a problem hiding this comment.
This line should be now removed
docs/spec-conformance.md
Outdated
| -------------|------------------------------------------|---------------------------------------------------------- | ||
| v1.1.0 | `SECCOMP_FILTER_FLAG_WAIT_KILLABLE_RECV` | [#3862](https://github.com/opencontainers/runc/pull/3862) | ||
| v1.1.0 | `.process.ioPriority` | [#3783](https://github.com/opencontainers/runc/pull/3783) | ||
| v1.1.0 | rsvd hugetlb cgroup | TODO ([#3859](https://github.com/opencontainers/runc/issues/3859)) |
There was a problem hiding this comment.
This should be a separate PR?
There was a problem hiding this comment.
Seems to have been implemented in:
Signed-off-by: utam0k <k0ma@utam0k.jp>
| Priority: tc.priority, | ||
| } | ||
| config := &configs.Config{ | ||
| Rootfs: "/var", |
There was a problem hiding this comment.
(This value looks unusual, but it doesn’t matter here)
There was a problem hiding this comment.
It seems we need to set an existing dir. I tried to delete this line and got following error.
validator_test.go|869| iopriority: 0, expected nil, got error invalid rootfs: stat : no such file or directory
opencontainers/runtime-spec#1191