Skip to content

specconv: avoid mapping "acl" to MS_POSIXACL#3739

Merged
kolyshkin merged 1 commit intoopencontainers:mainfrom
AkihiroSuda:fix-acl
Mar 20, 2023
Merged

specconv: avoid mapping "acl" to MS_POSIXACL#3739
kolyshkin merged 1 commit intoopencontainers:mainfrom
AkihiroSuda:fix-acl

Conversation

@AkihiroSuda
Copy link
Copy Markdown
Member

From torvalds/linux@caaef1b :

In fact SB_POSIXACL is an internal flag, and accepting MS_POSIXACL on
the mount(2) interface is possibly a bug.

Fix #3738

kolyshkin
kolyshkin previously approved these changes Feb 10, 2023
Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe it makes sense to add a comment saying that we do not map "acl/noacl" to unix.MS_POSIXACL as Linux kernel does not support it (or just link to #3738). This way, the flag/option won't be re-added by someone.

From torvalds/linux@caaef1b :

> In fact SB_POSIXACL is an internal flag, and accepting MS_POSIXACL on
> the mount(2) interface is possibly a bug.

Fix issue 3738

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda
Copy link
Copy Markdown
Member Author

Maybe it makes sense to add a comment saying that we do not map "acl/noacl" to unix.MS_POSIXACL as Linux kernel does not support it (or just link to #3738). This way, the flag/option won't be re-added by someone.

done

Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin kolyshkin added this to the 1.2.0 milestone Feb 16, 2023
@kolyshkin kolyshkin enabled auto-merge February 22, 2023 10:58
@AkihiroSuda AkihiroSuda requested a review from a team February 28, 2023 00:22
@kolyshkin
Copy link
Copy Markdown
Contributor

@opencontainers/runc-maintainers PTAL

@kolyshkin kolyshkin merged commit e67dc39 into opencontainers:main Mar 20, 2023
@cyphar cyphar mentioned this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mount: acl implementation is probably wrong

3 participants