Skip to content

[DNM] integration test for #3707#3720

Closed
kolyshkin wants to merge 1 commit intoopencontainers:mainfrom
kolyshkin:3707-unit-test
Closed

[DNM] integration test for #3707#3720
kolyshkin wants to merge 1 commit intoopencontainers:mainfrom
kolyshkin:3707-unit-test

Conversation

@kolyshkin
Copy link
Contributor

@kolyshkin kolyshkin commented Feb 2, 2023 •
edited
Loading

This is an integration test for the fix in #3707

@kolyshkin kolyshkin marked this pull request as draft February 2, 2023 21:10
@kolyshkin kolyshkin changed the title integration test for #3707 [DNM] integration test for #3707 Feb 2, 2023
@kolyshkin kolyshkin force-pushed the 3707-unit-test branch 2 times, most recently from bbb03ce to 3cf6c68 Compare February 2, 2023 21:11
@kolyshkin kolyshkin mentioned this pull request Feb 2, 2023
Merged
@kolyshkin
Copy link
Contributor Author

kolyshkin commented Feb 3, 2023

I will now retry the same test with the fix removed

@kolyshkin
tests/int: test for /dev/null owner regression
65c94b8 
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
Copy link
Contributor Author

kolyshkin commented Feb 3, 2023

OK, I have tested that the added case fails without the fix (#3707) and passes with it, as it should.

not ok 69 runc exec --user vs /dev/null ownership
# (in test file tests/integration/exec.bats, line 144)
#   `[ "$UG" = "0:0" ]' failed
# runc spec (status=0):
# 
# runc run -d --console-socket /tmp/bats-run-18871/runc.Cuk9gE/tty/sock test_busybox (status=0):
# 
# crw-rw-rw- 1 root root 1, 3 Feb  3 00:00 /dev/null
# uid=1000 gid=1000
# crw-rw-rw- 1 runneradmin root 1, 3 Feb  3 00:00 /dev/null

@kolyshkin kolyshkin closed this Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@kolyshkin