runc checkpoint: destroy only on success#3655
Merged
mrunalp merged 1 commit intoopencontainers:mainfrom Nov 22, 2022
Merged
Conversation
If checkpointing has failed, the container is kept running. We do not want to, and we can't remove it in such case. Do not try to remove the container if there's an error from checkpointing. This avoids an unclear error message from destroy() saying "container still running" or "container paused". While at it, avoid using defer since it does not make a lot of sense here. Fixes: opencontainers#3577 Reported-by: gosoon <tianfeiyu0@gmail.com> Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Contributor
Author
|
@gosoon @adrianreber @rst0git PTAL |
adrianreber
approved these changes
Nov 4, 2022
Contributor
adrianreber
left a comment
There was a problem hiding this comment.
It feels like we had to deal with something like this a couple of years ago. Looks good to me.
AkihiroSuda
approved these changes
Nov 14, 2022
Contributor
Author
|
@thaJeztah PTAL (low handing fruit here) |
mrunalp
approved these changes
Nov 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If checkpointing has failed, the container is kept running. We do not want to, and we can't remove it in such case.
Do not try to remove the container if there's an error from checkpointing.
This avoids an unclear error message from destroy() saying "container still running" or "container paused".
While at it, avoid using defer since it does not make a lot of sense here.
Fixes: #3577