ci: enable extra linters for new code #3304
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new GHA CI job which runs a few extra linters. This is only done for pull requests, and should only warn about new code. The justification is simple: we want more linters, but since this is not a new project, adding a new linter meaning we have to fix all the existing warnings. In some cases having all the warnings fixed is difficult and takes time, plus it is usually a low priority task. Therefore, we are stuck with inability to add new linters because we can't fix all their warnings. Meanwhile, new pull requests add more code which is not linted. This is an attempt to break this vicious cycle. Let's enable godot and revive for now and see how it is going. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Contributor
Author
|
It works! Removing the test commit, moving out of draft |
AkihiroSuda
approved these changes
Dec 1, 2021
Contributor
Author
|
@thaJeztah PTAL |
mrunalp
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new GHA CI job which runs a few extra linters. This is only
done for pull requests, and should only warn about new code.
The justification is simple: we want more linters, but since this is not
a new project, adding a new linter meaning we have to fix all the
existing warnings. In some cases having all the warnings fixed is
difficult and takes time, plus it is usually a low priority task.
Therefore, we are stuck with inability to add new linters because we
can't fix all their warnings. Meanwhile, new pull requests add more
code which is not linted.
This is an attempt to break this vicious cycle. Let's enable godot
and revive for now and see how it is going.