libct/nsenter: fix unused-result warning#3168
Merged
AkihiroSuda merged 1 commit intoopencontainers:masterfrom Aug 18, 2021
Merged
libct/nsenter: fix unused-result warning#3168AkihiroSuda merged 1 commit intoopencontainers:masterfrom
AkihiroSuda merged 1 commit intoopencontainers:masterfrom
Conversation
Commit 2bab4a5 resulted in a warning from gcc: nsexec.c: In function ‘write_log’: nsexec.c:171:2: warning: ignoring return value of ‘write’, declared with attribute warn_unused_result [-Wunused-result] 171 | write(logfd, json, ret); | ^~~~~~~~~~~~~~~~~~~~~~~ As there's nothing we can or want to do in case write fails, let's just tell the compiler we're not going to use it. Fixes: 2bab4a5 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This was referenced Aug 17, 2021
This was referenced Aug 17, 2021
Closed
mrunalp
approved these changes
Aug 17, 2021
AkihiroSuda
approved these changes
Aug 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative to #3165 / #3154.
Commit 2bab4a5 resulted in a warning from gcc:
As there's nothing we can or want to do in case write fails,
let's just tell the compiler we're not going to use it.
Fixes: 2bab4a5
1.0 backport: #3169