CI: Validate compilation without buildtags#3164
Merged
thaJeztah merged 1 commit intoopencontainers:masterfrom Aug 17, 2021
Merged
CI: Validate compilation without buildtags#3164thaJeztah merged 1 commit intoopencontainers:masterfrom
thaJeztah merged 1 commit intoopencontainers:masterfrom
Conversation
Today we support the seccomp build tag only that is used by default. However, we are not testing that compiling without any build tag works. I found the CI didn't catch this when working on opencontainers#2682, that the CI was green but compilation without build tags was broken. We test compilation without build tags only, compilation with the only build tag supported is done extensively in other actions. Signed-off-by: Rodrigo Campos <rodrigo@kinvolk.io>
Member
Author
|
Please note that the action added is included in the checks for this PR, so you can easily see how it would look like |
kolyshkin
approved these changes
Aug 16, 2021
Contributor
kolyshkin
left a comment
There was a problem hiding this comment.
Theoretically, we can add BUILDTAGS as another matrix dimension in test.yml. Practically, there will be too much jobs, so this small addition is better.
LGTM
Member
Yes, I was thinking if we needed other configurations, but we can always look at that if needed. |
Member
|
We should also consider changing to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today we support the seccomp build tag only that is used by default.
However, we are not testing that compiling without any build tag works.
I found the CI didn't catch this when working on #2682, that the CI was
green but compilation without build tags was broken.
We test compilation without build tags only, compilation with the only
build tag supported is done extensively in other actions.
Signed-off-by: Rodrigo Campos rodrigo@kinvolk.io