Make cgroup freezer only care about current control group (carry #3065)#3081
Merged
AkihiroSuda merged 2 commits intoopencontainers:masterfrom Jul 12, 2021
Merged
Make cgroup freezer only care about current control group (carry #3065)#3081AkihiroSuda merged 2 commits intoopencontainers:masterfrom
AkihiroSuda merged 2 commits intoopencontainers:masterfrom
Conversation
If a control group is frozen, all its descendants will report FROZEN in freezer.state cgroup file. OTOH cgroup v2 cgroup.freeze is not reporting the cgroup as frozen unless it is frozen directly (i.e. not via an ancestor). Fix the discrepancy between v1 and v2 drivers behavior by looking into freezer.self_freezing cgroup file, which, according to kernel documentation, will show 1 iff the cgroup was frozen directly. Co-authored-by: Kir Kolyshkin <kolyshkin@gmail.com> Signed-off-by: Odin Ugedal <odin@uged.al> Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This test the issues fixed by the two preceding commits. Co-Authored-By: Kir Kolyshkin <kolyshkin@gmail.com> Signed-off-by: Odin Ugedal <odin@uged.al> Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This was referenced Jul 9, 2021
odinuge
approved these changes
Jul 9, 2021
| t.Fatalf("expected container cgroup path %q to be under pod cgroup path %q", | ||
| cm.Path("freezer"), pm.Path("freezer")) | ||
| } | ||
| // Check the container is not reported as frozen despite the frozen parent. |
Closed
mrunalp
approved these changes
Jul 9, 2021
AkihiroSuda
approved these changes
Jul 12, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the same as #3065 with a few nitpicks and minor fixes on top.
Fixes the issue (frozen containers) that led to runc bump to 1.0.0 reverted in kubernetes.
Diff from #3065 (not including commit messages):
1.0 backport: #3085