[1.0] tests/int/no_pivot: fix for new kernels#3075
Merged
mrunalp merged 1 commit intoopencontainers:release-1.0from Jul 8, 2021
Merged
[1.0] tests/int/no_pivot: fix for new kernels#3075mrunalp merged 1 commit intoopencontainers:release-1.0from
mrunalp merged 1 commit intoopencontainers:release-1.0from
Conversation
The test is failing like this: not ok 70 runc run --no-pivot must not expose bare /proc # (in test file tests/integration/no_pivot.bats, line 20) # `[[ "$output" == *"mount: permission denied"* ]]' failed # runc spec (status=0): # # runc run --no-pivot test_no_pivot (status=1): # unshare: write error: Operation not permitted Apparently, a recent kernel commit db2e718a47984b9d prevents root from doing unshare -r unless it has CAP_SETFPCAP. Add the capability for this specific test. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 1bbeada) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
This was referenced Jul 8, 2021
Closed
AkihiroSuda
approved these changes
Jul 8, 2021
mrunalp
approved these changes
Jul 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #3051 to release-1.0 branch to fix CI. Clean cherry-pick, no issues, original description follows.
The test is failing like this:
Apparently, a recent kernel commit db2e718a47984b9d prevents
root from doing unshare -r unless it has CAP_SETFPCAP.
Add the capability for this specific test.
Signed-off-by: Kir Kolyshkin kolyshkin@gmail.com
(cherry picked from commit 1bbeada)
Signed-off-by: Kir Kolyshkin kolyshkin@gmail.com