Skip to content

ci: add go1.17#3021

Merged
mrunalp merged 1 commit intoopencontainers:masterfrom
kolyshkin:go-1.17beta1
Aug 18, 2021
Merged

ci: add go1.17#3021
mrunalp merged 1 commit intoopencontainers:masterfrom
kolyshkin:go-1.17beta1

Conversation

@kolyshkin
Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin commented Jun 10, 2021 •
edited
Loading

Keeping this as draft until go1.17 is released. Will rebase periodically to test master with go 1.17.

  • Jul 13: updated to rc1.
  • Aug 3: updated to rc2.
  • Aug 16: updated to GA.

1.0 backport: #3299

@kolyshkin kolyshkin force-pushed the go-1.17beta1 branch 2 times, most recently from 68005a2 to 1020824 Compare June 16, 2021 19:59
@kolyshkin kolyshkin force-pushed the go-1.17beta1 branch 3 times, most recently from 02ad38d to 194b806 Compare June 29, 2021 19:14
@kolyshkin kolyshkin mentioned this pull request Jun 29, 2021
Closed
@kolyshkin
Copy link
Copy Markdown
Contributor Author

kolyshkin commented Jun 29, 2021

CI failure is unrelated (#3050)

@kolyshkin
Copy link
Copy Markdown
Contributor Author

kolyshkin commented Jul 12, 2021

Rebased.

@kolyshkin kolyshkin changed the title ci: add go1.17beta1 ci: add go1.17rc1 Jul 14, 2021
@kolyshkin
Copy link
Copy Markdown
Contributor Author

kolyshkin commented Jul 14, 2021

Updated to 1.17-rc1

@kolyshkin
Copy link
Copy Markdown
Contributor Author

kolyshkin commented Jul 14, 2021

Removed go 1.15

@kolyshkin kolyshkin force-pushed the go-1.17beta1 branch 2 times, most recently from 8b42a04 to 7a0053c Compare July 20, 2021 22:18
@kolyshkin kolyshkin force-pushed the go-1.17beta1 branch 2 times, most recently from af5fae9 to 6db56cf Compare August 4, 2021 19:57
@AkihiroSuda
Copy link
Copy Markdown
Member

AkihiroSuda commented Aug 16, 2021

We have 1.17 GA now https://golang.org/dl/

@AkihiroSuda AkihiroSuda added the backport/1.0-todo A PR in main branch which needs to be backported to release-1.0 label Aug 16, 2021
@kolyshkin kolyshkin marked this pull request as ready for review August 16, 2021 21:52
@kolyshkin
Copy link
Copy Markdown
Contributor Author

kolyshkin commented Aug 16, 2021 •
edited
Loading

Updated to GA; rebased; no longer a draft.

@AkihiroSuda AkihiroSuda changed the title ci: add go1.17rc1 ci: add go1.17 Aug 16, 2021
AkihiroSuda
AkihiroSuda reviewed Aug 16, 2021
View reviewed changes
.github/workflows/test.yml
fail-fast: false
matrix:
go-version: [1.15.x, 1.16.x]
go-version: [1.15.x, 1.16.x, 1.17.x]
Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda Aug 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dockerfile needs to be update

runc/Dockerfile

Line 1 in 55e93b8

ARG GO_VERSION=1.16

Copy link
Copy Markdown
Member

@AkihiroSuda AkihiroSuda Aug 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we drop support for Go 1.15?

Copy link
Copy Markdown
Contributor Author

@kolyshkin kolyshkin Aug 18, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dockerfile needs to be update

done

Can we drop support for Go 1.15?

I'd say let's have it for some time as it just became unsupported a day ago.

This is also a separate issue; I'd like to add 1.17 now and drop 1.15 later and separately.

@kolyshkin
ci: add go1.17
a587180 
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@mrunalp mrunalp merged commit 9835e9c into opencontainers:master Aug 18, 2021
@kolyshkin kolyshkin deleted the go-1.17beta1 branch August 18, 2021 22:59
@AkihiroSuda AkihiroSuda mentioned this pull request Aug 20, 2021
Closed
@kolyshkin kolyshkin mentioned this pull request Nov 30, 2021
Merged
@kolyshkin kolyshkin added backport/1.0-done A PR in main branch which has been backported to release-1.0 and removed backport/1.0-todo A PR in main branch which needs to be backported to release-1.0 labels Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrunalp mrunalp mrunalp approved these changes

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

Assignees

No one assigned

Labels

area/ci backport/1.0-done A PR in main branch which has been backported to release-1.0 easy-to-review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kolyshkin @AkihiroSuda @mrunalp