Skip to content

Fix build-tags in libcontainer/devices#2851

Merged
kolyshkin merged 1 commit intoopencontainers:masterfrom
thaJeztah:fix_build_tags
Mar 23, 2021
Merged

Fix build-tags in libcontainer/devices#2851
kolyshkin merged 1 commit intoopencontainers:masterfrom
thaJeztah:fix_build_tags

Conversation

@thaJeztah
Copy link
Copy Markdown
Member

Allows importing this package on Windows (for the types)

relates to moby/moby#42143

Allows importing this package on Windows (for the types)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Copy Markdown
Member Author

@kolyshkin @AkihiroSuda ptal

This was needed, because libcontainer/config imports libcontainer/devices, which failed on Windows

@thaJeztah
Copy link
Copy Markdown
Member Author

@kolyshkin PTAL

Copy link
Copy Markdown
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolyshkin kolyshkin merged commit ec7ca2a into opencontainers:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants