vendor: bump mountinfo to v0.4.0#2657
Merged
cyphar merged 2 commits intoopencontainers:masterfrom Oct 22, 2020
Merged
Conversation
f2e7faa to
703b7b4
Compare
Member
Contributor
Author
done |
2da404e to
918b7b8
Compare
Contributor
Author
|
Took a liberty to make a minor change in the test case: - [[ ${lines[*]} == *"mount: permission denied"* ]]
+ [[ "$output" == *"mount: permission denied"* ]] |
Contributor
Author
|
@AkihiroSuda @mrunalp @cyphar PTAL |
Release notes: - https://github.com/moby/sys/releases/tag/mountinfo%2Fv0.4.0 In particular, this fixes a regression introduced in commit b8bf572 which checked the mountinfo.Root field in a FilterFunc, while Root was not set when calling a filter. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
For preventing regression like opencontainers#2647 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp> Signed-off-by: Aleksa Sarai <cyphar@cyphar.com> Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
918b7b8 to
f5c345c
Compare
AkihiroSuda
approved these changes
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release notes:
In particular, this fixes a regression introduced in commit b8bf572 (PR #2647)
which checked the
mountinfo.Rootfield in aFilterFunc, whileRootwasnot (yet) set when calling the filter.
Also add "runc run --no-pivot must not expose bare /proc" test by @AkihiroSuda
to prevent future regressions like this one.
Closes: #2655