Revert "rootfs: handle nested procfs mounts for MS_MOVE" + add a test#2654
Closed
AkihiroSuda wants to merge 2 commits intomasterfrom
Closed
Revert "rootfs: handle nested procfs mounts for MS_MOVE" + add a test#2654AkihiroSuda wants to merge 2 commits intomasterfrom
AkihiroSuda wants to merge 2 commits intomasterfrom
Conversation
b626821 to
2aa00eb
Compare
Member
|
This is actually a bug in |
cyphar
reviewed
Oct 20, 2020
| mountinfos, err := mountinfo.GetMounts(func(info *mountinfo.Info) (skip, stop bool) { | ||
| // Collect every sysfs and procfs filesystem, except for those which | ||
| // are non-full mounts or are inside the rootfs of the container. | ||
| if info.Root != "/" || |
Member
There was a problem hiding this comment.
It's overkill to revert it -- a simpler patch is to just remove this info.Root != "/" clause which won't cause us to revert the fix (the ENOENT check later in the patch is sufficient to fix that bug).
Member
Author
There was a problem hiding this comment.
Let's revert it first and then revendor moby/sys#50 when it is merged
Contributor
There was a problem hiding this comment.
I agree with @cyphar here -- for the reason of having a slightly less dramatic git history.
For preventing regression like #2647 Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Member
Author
|
Added a new commit: |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #2647 due to a security issue
Reopens #2639